Avoid writing NaN and Infinity with json format table #24558
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 23, 2024
| @@ -123,7 +123,16 @@ else if (REAL.equals(type)) { | |||
| return (generator, block, position) -> generator.writeNumber(REAL.getFloat(block, position)); | |||
| } | |||
| else if (DOUBLE.equals(type)) { | |||
| return (generator, block, position) -> generator.writeNumber(DOUBLE.getDouble(block, position)); | |||
| return (generator, block, position) -> { | |||
There was a problem hiding this comment.
'NaN' and 'Infinity' getting casted as Double it seems. It goes through double datatype.
There was a problem hiding this comment.
I don't think so. Please try CREATE TABLE test_nan WITH (format = 'json') AS SELECT real 'NaN' a;.
sug-ghosh
force-pushed
the
invalid_json_write
branch
from
360d7a0 to
a0b1253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20395 #20395
This pr will fix inserting NaN and Infinity into table as Json Format.
In hive, if we insert NaN or Infinity in json format table, it would store that as NULL, which readable from Trino. We can go that path also if we want to create table to be successful.
@ebyhr @hashhar
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: